Handle media download failures #138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ey submitted fails to download
Deploy build 779 of
|
zekehuntergreen
approved these changes
Feb 11, 2025
| @@ -88,7 +91,7 @@ export const TranscriptionOutputSuccess = TranscriptionOutputBase.extend({ | |||
| translationOutputBucketKeys: z.optional(OutputBucketKeys), | |||
| }); | |||
|
|
|||
| export const MediaDownloadFailure = z.object({ | |||
| export const MediaDownloadFailure = OutputBase.extend({ | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
I spotted that the media download serivice doesn't actually currently have permission to write to the transcription output queue, so if a media download fails it can't tell the user.
This fixes that, and adds a step to the output handler to send an email to the user explaining what might have happened. It looks like this:
How to test
Tested on CODE