Media download - stop inferring filename from info.json, use --print template instead #142
+35
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy build 806 of
|
…ring from info.json
…ent, fix running locally
philmcmahon
force-pushed
the
pm-print-filepath-ytdlp
branch
from
cbd208f to
57aa524
Compare
zekehuntergreen
approved these changes
Feb 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
We keep having problems with different info.json formats coming from different media websites. This change modifies the transcription service so that instead of relying on the 'filename' field in the info.json file, it uses --print-to-file with
after_move:filepathto get an accurate filename. I learned about this in the output section of the docs, --print-to-file is documented hereHow to test
I've tested this on CODE with various links, seems to work