fix: Avoid ENOENT on globs with non-existant base paths#137
Open
XCompWiz wants to merge 1 commit intogulpjs:masterfrom
Open
fix: Avoid ENOENT on globs with non-existant base paths#137XCompWiz wants to merge 1 commit intogulpjs:masterfrom
XCompWiz wants to merge 1 commit intogulpjs:masterfrom
Conversation
Member
|
@XCompWiz I was wondering if you have some time to add a regression test. I'd like to land this but I'll have to wait for a test or find time to add one myself. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #134
I tested this code live, but rewrote it on the web editor, so it's effectively untested. The approach worked in the field.
A regression test would be beneficial, but I've not the time to do more than this quick sketch.