Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "1d" sweep #484

Closed
wants to merge 3 commits into from
Closed

Fix "1d" sweep #484

wants to merge 3 commits into from

Conversation

MatthiasJ1
Copy link
Contributor

with BuildSketch() as s:
    spine = Polyline((0,0), (1,10), (10,10), mode=PRIVATE)
    sect = spine.wire().perpendicular_line(2, 0)
    sweep(sect, spine, transition=Transition.RIGHT)

Before

Screenshot1

After

Screenshot

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a433707) 96.00% compared to head (f4e3e1a) 95.99%.
Report is 1 commits behind head on dev.

Files Patch % Lines
src/build123d/topology.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #484      +/-   ##
==========================================
- Coverage   96.00%   95.99%   -0.02%     
==========================================
  Files          24       24              
  Lines        7458     7461       +3     
==========================================
+ Hits         7160     7162       +2     
- Misses        298      299       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gumyr
Copy link
Owner

gumyr commented Feb 4, 2024

Fixed with commit 7b5e154. Please follow the contribution steps described here: https://github.com/gumyr/build123d/blob/dev/CONTRIBUTING.md for your next PR, this fix didn't pass code coverage.

@gumyr gumyr closed this Feb 4, 2024
@MatthiasJ1
Copy link
Contributor Author

Your version of the fix passes your code coverage and yet it is less robust. The following is a semantically valid operation which works in my PR but fails in yours:

sweep(Line((0,1), (0,0)) + Line((0,0), (1,-1)), Line(0, 10))

I am happy to make contributions if you find them useful, but I am not willing to comply with arbitrary ancillary requirements. If that is a deal-breaker, I respect your principles, but I'm just doing this for fun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants