Include rounding in Plane(face) and Plane(loc) #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #511 +/- ##
=======================================
Coverage 96.16% 96.17%
=======================================
Files 24 24
Lines 7467 7471 +4
=======================================
+ Hits 7181 7185 +4
Misses 286 286 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platform specific handling of floats is causing tests on aarch64 to fail in relation to orientation. After a lot of investigation and test runs using flyci, rounding to 14 decimal places seems to provide reliable behavior on both x86_64 and aarch64.
This is related to issue #478 and fixes one of the two failing tests mentioned there. This was not, as previously postulated, related to quaternion vs. orientation vector comparison.