Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TooTallToby tutorials: unbreak and test. #912

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

fischman
Copy link
Contributor

@fischman
Copy link
Contributor Author

FYI @jdegenstein. LMK if you'd rather I not replace your PPP0110 solution (and if you have a fix in mind already).

- Unbreak the three broken tutorials (fixes gumyr#848)
  - This involved a rewrite of PPP-01-10 because I already had my own
    solution to that one and I couldn't easily tell what was going
    wrong with the previous solution.
- Add assertions to all the tutorials so that non-raising means success
- Add the TTT examples to `test_examples.py` added recently for gumyr#909
- Also added sympy to development dependencies since one of the TTT
  examples uses it.
@fischman fischman force-pushed the ttt-unbreak-and-test branch from 7b9c87f to 3e8bb44 Compare February 23, 2025 06:49
Copy link

codecov bot commented Feb 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.91%. Comparing base (bda0a6a) to head (3e8bb44).
Report is 3 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #912      +/-   ##
==========================================
+ Coverage   96.73%   96.91%   +0.18%     
==========================================
  Files          32       32              
  Lines        9434     9434              
==========================================
+ Hits         9126     9143      +17     
+ Misses        308      291      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fischman
Copy link
Contributor Author

@gumyr WDYT, worth testing TTT examples as part of automated testing?

@jdegenstein
Copy link
Collaborator

@fischman FYI TTT examples are (sort of) tested through the benchmarking workflow (in a separate python script)

@fischman
Copy link
Contributor Author

@fischman FYI TTT examples are (sort of) tested through the benchmarking workflow (in a separate python script)

Thanks for the heads-up, I was unaware of that before.
Seems suboptimal that the examples' code is duplicated in the tests/ subdirectory (because of the likelihood of drift as one or the other place is edited, and the other is forgotten, and also because edits must be duplicated). Also ttt-23-t-24-curved_support is missing from the test.

Do you prefer to keep the structure at HEAD, or are you suggesting I keep this PR moving forward and delete the test_benchmarks copy of the examples, or something else?
(maybe test_benchmarks should run test_examples?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix TTT tutorials: 23-T-24 Curved Support, 01-02-post-cap, 01-10-light-cap
2 participants