Closed
Conversation
- this should always require retraining
Collaborator
Author
|
Shelving this for now in favor of a more incremental approach to more quickly get us where we need to be for the OPAQUE paper. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR makes an overhaul of validation in
adeftitAdeftDisambiguatorand tests.This PR is a work in progress. The tests are not going to pass until I populate the
1.0.0-devfolder on S3 with testing resources. I'm just posting this for the sake of visibility. Note also that this is a PR into av1.0.0-devbranch. I may back down from committing to a stable1.0.0release, but it seems like a worthy goal to shoot for.