Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Multiple Default Peers per User #230

Closed
wants to merge 1 commit into from

Conversation

ReeseWang
Copy link
Contributor

I've introduced two new configuration options: default_peers_per_user and default_peer_names. Now, when a user is created, the program will automatically generate a number of peers specified by default_peers_per_user. Should default_peers_per_user exceed the number of names provided in default_peer_names, the program will revert to the existing naming convention for any additional peers.

Should this enhancement be approved, I plan to update the documentation accordingly within this pull request.

To maintain compatibility with existing setups, I've set default_peers_per_user to default to 1. Furthermore, I've retained the create_default_peer option for now, although it could potentially be phased out. In the future, simply setting default_peers_per_user to 0 could serve as the indicator for whether or not peers should be created.

@h44z
Copy link
Owner

h44z commented Mar 29, 2024

In principle, this sounds OK, but we need to update the documentation to describe this feature. Also, remove the create_default_peer configuration option (as v2 is not yet finally released, this breaking change is fine for me).

@h44z h44z closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants