React log in page #148
Open
React log in page #148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is definitely just a start - I got help from: https://www.youtube.com/watch?v=qH4pJISKeoI Let me know if I'm on the right track! Also added <label> in index.css for the <label> element you see in LogIn.js
This was the original file I used in my local computer to get this result:
Can now run!
Removing App.js made it crash... not sure why
Crashes when onChange() function is called, I think due to type errors.
CurtisMIT
requested changes
Apr 8, 2021
There was a problem hiding this comment.
@jerryliangxia Was wondering whether you could resolve the merge conflicts? I think rebasing would be a good idea? Also was wondering whether you could add a route for the login page in the routes folder and import your component there, and move your LogIn page component within the pages folder? Was wondering whether you could convert the implementation of the LogIn component into a functional component using hooks? Thanks!
celinehuang
reviewed
Apr 12, 2021
celinehuang
reviewed
Apr 12, 2021
celinehuang
reviewed
Apr 12, 2021
celinehuang
reviewed
May 5, 2021
Removed comments, deleted login.js and login.css files, and created a new file "index.tsx" under "pages" that displays a rough log-in form.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Write a quick summary of your changes here. Make sure to provide context for people that may be unfamiliar with what you're working on
Attached is an image of what I had working in my local computer.
Test Plan
How did you test your changes?
Related Issues
Which issues does this PR resolve/work on?
Closes #