Fix: Lost schema of S3 URL. #1893
Open
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fukumoto-ts
force-pushed
the
feature/fix-lost-s3-url-schema
branch
from
d5c2f64 to
ca9b8e6
Compare
Signed-off-by: Takeru Fukumoto <[email protected]>
fukumoto-ts
force-pushed
the
feature/fix-lost-s3-url-schema
branch
from
ca9b8e6 to
9060402
Compare
fukumoto-ts
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where the S3 URL lost its HTTPS scheme when a region was specified other than "us-east-1".
- Ensures that the S3 endpoint always includes the "https://" scheme.
- Targets the URL construction in the S3 image upload function.
Comments suppressed due to low confidence (1)
lib/imageRouter/s3.js:54
- The updated endpoint now correctly includes the HTTPS scheme for non-'us-east-1' regions, which fixes the lost schema error. Please verify that similar URL constructions in related modules consistently implement the HTTPS protocol.
s3Endpoint = `https://s3-${config.s3.region}.amazonaws.com`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close: #1892
Fix the erroneous change in #1762.