Skip to content

BugFix: Was able to create a component with new keyword #798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

BugFix: Was able to create a component with new keyword #798

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e3a9965
fixed: component no longer can be created with `new` keyword with ref…
migus88 Aug 4, 2025
26272bd
removed unused using
migus88 Aug 4, 2025
df1f60b
added unity define to wrap unity specific code
migus88 Aug 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion VContainer/Assets/VContainer/Runtime/Internal/ReflectionInjector.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
using System;
using System.Collections.Generic;
using System.Runtime.CompilerServices;
using System.Reflection;

namespace VContainer.Internal
{
Expand Down Expand Up @@ -31,6 +30,12 @@ public void Inject(object instance, IObjectResolver resolver, IReadOnlyList<IInj

public object CreateInstance(IObjectResolver resolver, IReadOnlyList<IInjectParameter> parameters)
{
#if UNITY_2020_1_OR_NEWER
if (typeof(UnityEngine.Component).IsAssignableFrom(injectTypeInfo.Type))
{
throw new NotSupportedException($"UnityEngine.Component:{injectTypeInfo.Type.Name} cannot be `new`");
}
#endif
var parameterInfos = injectTypeInfo.InjectConstructor.ParameterInfos;
var parameterKeys = injectTypeInfo.InjectConstructor.ParameterKeys;
var parameterValues = CappedArrayPool<object>.Shared8Limit.Rent(parameterInfos.Length);
Expand Down
Loading