[MINOR] Add support for hybrid_36 format - issue #184#185
Open
amjjbonvin wants to merge 12 commits into
Open
Conversation
rvhonorato
requested changes
May 15, 2026
Member
rvhonorato
left a comment
There was a problem hiding this comment.
This code was copied from the cctbx_project, the functions were taken directly from it - see here for example and the license conditions are not being met.
Please check the source code license agreements and make the edits here
Member
|
This PR is also adding a feature that requires a minor version number - check the CONTRIBUTING.md |
Member
Author
Which is in the name the pull request as indicated. That should trigger the minor version updated if I am correct. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Edited
pdb_reatom,pdb_tidyandpdb_fromcifto add an option to enable the hybrid_36 format that will allow to handle/write PDB files with more than 99999 atoms.Added tests for the news options