Skip to content

[MINOR] Add support for hybrid_36 format - issue #184#185

Open
amjjbonvin wants to merge 12 commits into
masterfrom
hybrid36
Open

[MINOR] Add support for hybrid_36 format - issue #184#185
amjjbonvin wants to merge 12 commits into
masterfrom
hybrid36

Conversation

@amjjbonvin
Copy link
Copy Markdown
Member

@amjjbonvin amjjbonvin commented May 8, 2026

Edited pdb_reatom, pdb_tidy and pdb_fromcif to add an option to enable the hybrid_36 format that will allow to handle/write PDB files with more than 99999 atoms.

Added tests for the news options

@amjjbonvin amjjbonvin self-assigned this May 8, 2026
@amjjbonvin amjjbonvin changed the title Add support for hybrid_36 format - issue #184 [MINOR] Add support for hybrid_36 format - issue #184 May 8, 2026
@amjjbonvin amjjbonvin changed the title [MINOR] Add support for hybrid_36 format - issue #184 [FEATURE] Add support for hybrid_36 format - issue #184 May 10, 2026
@amjjbonvin amjjbonvin changed the title [FEATURE] Add support for hybrid_36 format - issue #184 [MINOR] Add support for hybrid_36 format - issue #184 May 10, 2026
Copy link
Copy Markdown
Member

@rvhonorato rvhonorato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code was copied from the cctbx_project, the functions were taken directly from it - see here for example and the license conditions are not being met.

Please check the source code license agreements and make the edits here

@rvhonorato
Copy link
Copy Markdown
Member

This PR is also adding a feature that requires a minor version number - check the CONTRIBUTING.md

@amjjbonvin
Copy link
Copy Markdown
Member Author

This PR is also adding a feature that requires a minor version number - check the CONTRIBUTING.md

Which is in the name the pull request as indicated. That should trigger the minor version updated if I am correct.
And the CONTRIBUTING.md doc is wrong in stating that FEATURE should be added as this triggers a CI error.

@rvhonorato rvhonorato linked an issue May 15, 2026 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add support for hybrid36 format allowing >99999 atoms

2 participants