fix re-usage of SSO-based accounts for LDAP login #7407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In pull request haiwen#6903 the SSO_LDAP_USE_SAME_UID field was introduced. But this change only took care for the following order of login actitivies: 1. login via LDAP -> account is created 2. login via SSO -> account is re-used The opposite order of login activities (first SSO, later LDAP) failed with the following error message: > [ERROR] seahub.base.accounts:1004 authenticate ldap user [email protected] not found. The introduction of SSO_LDAP_USE_SAME_UID lacked the fallback procedure from LDAP to SSO. This commit fixes that issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In pull request #6903 the SSO_LDAP_USE_SAME_UID field was introduced.
But this change only took care for the following order of login actitivies:
The opposite order of login activities (first SSO, later LDAP) failed with the following error message:
The introduction of SSO_LDAP_USE_SAME_UID lacked the fallback procedure from LDAP to SSO.
This commit fixes that issue.