fix: fix seaf-fuse.sh pgrep matching with itself #7433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The script `seaf-fuse.sh` uses pgrep to check if `seaf-fuse` is already running and therefore matches with itself, as both the process and script contain `seaf-fuse`. So the script can never run. This change changes the pgrep pattern from `seaf-fuse` to `bin/seaf-fuse` so that the binary is matched instead of both script and binary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The script
seaf-fuse.shuses pgrep to check ifseaf-fuseis already running and therefore matches with itself, as both the process and script containseaf-fuse. So the script can never run.This change changes the pgrep pattern from
seaf-fusetobin/seaf-fuseso that the binary is matched instead of both script and binary.