Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallet: add create auction txs #49

Merged
merged 3 commits into from
Jul 15, 2022

Conversation

rithvikvibhu
Copy link
Member

handshake-org/hsd#529 added a way to create auction transactions in advance.
This PR adds it to WalletClient.

Copy link
Member

@pinheadmz pinheadmz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you -- how about adding a CLI command in hsw-cli as well? You can use mktx/createTX() as a template I think. Be sure you add a help message describing the method. Finally, open a PR https://github.com/handshake-org/handshake-org.github.io adding CLI, cURL and JS methods to the API docs?

<3 <3 <3

...and by the way, if you enjoyed writing this PR there are a ton of new API endpoints that we need to add to the client:

#34

...and docs 😬

handshake-org/handshake-org.github.io#123

* @param {Object} options
* @param {String} options.name
* @param {Number} options.bid
* @param {Number} options.lockup
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

might need to include passphrase as well, I see that as an option in hsd wallet/http.js

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added passphrase

@rithvikvibhu rithvikvibhu force-pushed the create-auction-txs branch from 2d16665 to 337e73e Compare May 1, 2022 11:40
rithvikvibhu added a commit to rithvikvibhu/handshake-org.github.io that referenced this pull request May 1, 2022
rithvikvibhu added a commit to rithvikvibhu/handshake-org.github.io that referenced this pull request May 1, 2022
@rithvikvibhu
Copy link
Member Author

Turns out I had missed adding to Wallet class (the second half copy in the same file 😕). Fixed that and added to hsw-cli.

$ mkauctiontxs [name] [bid] [lockup] [broadcast]: Create bid and reveal transactions.

Will update the command name if needed.

And docs updated in handshake-org/handshake-org.github.io#148

rithvikvibhu added a commit to rithvikvibhu/handshake-org.github.io that referenced this pull request Jul 14, 2022
rithvikvibhu added a commit to rithvikvibhu/handshake-org.github.io that referenced this pull request Jul 14, 2022
@pinheadmz pinheadmz force-pushed the create-auction-txs branch from 2670ca5 to d23f4c4 Compare July 15, 2022 14:52
pinheadmz pushed a commit to rithvikvibhu/handshake-org.github.io that referenced this pull request Jul 15, 2022
@pinheadmz pinheadmz merged commit 926861b into handshake-org:master Jul 15, 2022
@rithvikvibhu rithvikvibhu deleted the create-auction-txs branch July 15, 2022 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants