-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wallet: add create auction txs #49
wallet: add create auction txs #49
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you -- how about adding a CLI command in hsw-cli
as well? You can use mktx
/createTX()
as a template I think. Be sure you add a help message describing the method. Finally, open a PR https://github.com/handshake-org/handshake-org.github.io adding CLI, cURL and JS methods to the API docs?
<3 <3 <3
...and by the way, if you enjoyed writing this PR there are a ton of new API endpoints that we need to add to the client:
...and docs 😬
* @param {Object} options | ||
* @param {String} options.name | ||
* @param {Number} options.bid | ||
* @param {Number} options.lockup |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might need to include passphrase
as well, I see that as an option in hsd wallet/http.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added passphrase
2d16665
to
337e73e
Compare
Related hs-client PR: handshake-org/hs-client#49
Related hs-client PR: handshake-org/hs-client#49
Turns out I had missed adding to
Will update the command name if needed. And docs updated in handshake-org/handshake-org.github.io#148 |
Related hs-client PR: handshake-org/hs-client#49
Related hs-client PR: handshake-org/hs-client#49
Add function for handshake-org/hsd#529
2670ca5
to
d23f4c4
Compare
Related hs-client PR: handshake-org/hs-client#49
handshake-org/hsd#529 added a way to create auction transactions in advance.
This PR adds it to WalletClient.