Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readings not showing after updating to Mac OS Mojave #24

Closed
lay55 opened this issue Sep 25, 2018 · 12 comments
Closed

Readings not showing after updating to Mac OS Mojave #24

lay55 opened this issue Sep 25, 2018 · 12 comments

Comments

@lay55
Copy link

lay55 commented Sep 25, 2018

Trying to install it on Mac OS mojave

Pasting my full log here:

Registering platform 'homebridge-config-ui-x.config'
[9/26/2018, 2:56:09 AM] ---
[9/26/2018, 2:56:09 AM] Loaded plugin: homebridge-mi-hygrothermograph
Error: Cannot find module 'xpc-connection'
at Function.Module._resolveFilename (internal/modules/cjs/loader.js:581:15)
at Function.Module._load (internal/modules/cjs/loader.js:507:25)
at Module.require (internal/modules/cjs/loader.js:637:17)
at require (internal/modules/cjs/helpers.js:20:18)
at Object. (/usr/local/lib/node_modules/homebridge-mi-hygrothermograph/node_modules/noble/lib/mac/highsierra.js:7:21)
at Module._compile (internal/modules/cjs/loader.js:689:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:700:10)
at Module.load (internal/modules/cjs/loader.js:599:32)
at tryModuleLoad (internal/modules/cjs/loader.js:538:12)
at Function.Module._load (internal/modules/cjs/loader.js:530:3)

@lay55
Copy link
Author

lay55 commented Sep 25, 2018

Managed to solve this but the temperature and humidity reading still not showing. running Homebridge on Mac OS Mojave...please help

@lay55 lay55 changed the title Getting error "Cannot find module 'xpc-connection'" Readings not showing after updating to Mac OS Mojave Sep 25, 2018
@hannseman
Copy link
Owner

Hi! Looks like the Bluetooth-library this plugin is using does not yet support MacOS Mojave. See noble/noble#804.

I'll follow the issue in noble and release an update if needed as soon as Mojave support is available.

@BillS11
Copy link

BillS11 commented Oct 14, 2018

Thanks @hannseman for building this. I'm also using Mojave so will wait for the update once support is available. Cheers!

@lay55
Copy link
Author

lay55 commented Jan 4, 2019

Any update on macOS Mojave?

@hannseman
Copy link
Owner

hannseman commented Jan 21, 2019

@lay55 there was some effort on the noble-repository to create a maintained fork which brings support for Node 10 as that too currently is broken, see @abandonware/noble. There's another fork called noble-mac which brings support for macOS but it does not support Node 10 on other systems.

End-Of-Life for Node 6 is in April 2019 and Node 8 in December 2019. So if we switch to using noble-mac we would only be supporting abandoned Node versions by the end of this year. See https://github.com/nodejs/Release

I've opened an issue in that repository about bringing in macOS Mojave support: abandonware/noble#4. Unfortunately I haven't gotten any response yet.

One way to approach this could be to add each of the forks as optionalDependencies but that would make importing noble in the code hard. Another is to distribute two versions of this package, one which uses noble-mac and one which uses @abandonware/noble. Neither of these are preferable.

@hannseman
Copy link
Owner

I've also opened an issue on noble-mac to check if they are interested in depending on the @abandonware-fork. Timeular/noble-mac#23

This would enable us to get support for both Mojave and Node 10 on linux.

@hannseman
Copy link
Owner

hannseman commented Feb 21, 2019

An update on what's going on:

There's an open PR on @abandonware/noble. Looks like the author wants a vote for adding MacOS-support so please go in and add a :)

abandonware/noble#8

@hannseman
Copy link
Owner

If you still are interested in running this on MacOS Mojave I can inform you that abandonware/noble#8 have been merged. I'll try update to this new version ASAP.

@BillS11
Copy link

BillS11 commented Apr 15, 2019 via email

@hannseman
Copy link
Owner

I just released version 2.2.0 which brings support for MacOS Mojave. Please give it a try and tell me if it works so we can finally close this issue :-)

@BillS11
Copy link

BillS11 commented Apr 19, 2019

Just installed and confirmed working. Christmas has come very early!
Thank you so much!!!

@hannseman
Copy link
Owner

@BillS11 great to hear that! Thanks for the patience. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants