-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Node 10 compatibility #32
Conversation
Hi! Thanks for the PR. Yes I'm aware of that fork. The reason why I haven't switched is that I wanted to see if the author was interested in also bringing in support for MacOS Mojave as that to is broken, see #24. I've opened the PR abandonware/noble#4 but haven't gotten any response what in almost a month which made me wonder if that fork really is the way to go. But maybe it's better to actually get Node 10 support and then start thinking about MacOS Mojave support. The test suite is broken, it is probably caused by proxyquire patching |
I've also opened an issue on noble-mac to check if they are interested in depending on the @abandonware-fork. Timeular/noble-mac#23 This would enable us to get support for both Mojave and Node 10 on linux. |
Perfect! Could you also run prettier on the code? There's some errors https://travis-ci.org/hannseman/homebridge-mi-hygrothermograph/jobs/484840460#L697 |
Sorry I messed up your PR. Could you please rebase. You can remove:
As this PR fixes that. You can also remove Node 7 from the |
Working on it now… |
Awesome work! Thank you very much. Lets merge this. I'll make a new release ASAP. |
While official Noble repo adds support for Node 10, there's a fork that solved the compatibly issue published as @abandonware/noble.
For this fork I just modified the
package.json
andscanner.js
files.I'm currently running it on a Raspberry Pi and it works like a charm.