Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Node.js 7, add 10 and 11 (node) #33

Merged
merged 2 commits into from
Jan 26, 2019
Merged

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented Jan 21, 2019

Node.js 7 is out of support, 10 and node are the last stable long term support and the last stable versions.

Node.js 7 is out of support
@hannseman
Copy link
Owner

This package does not yet support Node 10 but please see #32 which would bring support for it.

I plan on dropping support for all versions below Node 8 when Node 10 is supported as Node 8 is End-Of-Life this April.

@EwoutH
Copy link
Contributor Author

EwoutH commented Jan 21, 2019

Interesting enough it passes on Node.js 10 and 11, but fails on 6.

Shall I add a allow_failures to Node.js 10 and 11 for now?

@hannseman
Copy link
Owner

hannseman commented Jan 21, 2019

Looks like the failure on 6 is because of a linting error. No idea why it only fails on 6, never seen that before. I think that the tests passes on 10 and above is because the broken dependency is bluetooth-hci-socket and it's marked as an optional dependency by noble. The installation actually crashes if you look at the logs. The reason why the tests then are able to run is because noble is mocked away in the tests.

Good idea! Please add allow_failures to 10 and 11 if they would start crashing hard.

@EwoutH
Copy link
Contributor Author

EwoutH commented Jan 21, 2019

For full integration with GitHub you probably also need to enable Travis CI in the GitHub Marketplace.

@hannseman
Copy link
Owner

I think you have an indentation error on the matrix-key causing a parse error on Travis CI.

image

https://travis-ci.org/hannseman/homebridge-mi-hygrothermograph/requests

@hannseman
Copy link
Owner

Regarding the Travis CI github app we're stuck on their old environment travis-ci.org but I've emailed them about being migrated to travis-ci.com. See https://docs.travis-ci.com/user/migrate/open-source-on-travis-ci-com/#existing-open-source-repositories-on-travis-ciorg

@hannseman hannseman merged commit 20b625c into hannseman:master Jan 26, 2019
@hannseman
Copy link
Owner

I did a quick fix. Thank you for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants