This repository has been archived by the owner on Sep 13, 2024. It is now read-only.
Move to a static build and remote rendering #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit takes the happo-plugin-gatsby library closer to what happo-plugin-storybook is doing: 1. invoke a static build 2. inject happo-specific javascript that remote workers understand 3. send the entire build to happo.io This is better for a few different reasons: - simpler - no longer a need for building yourself - most likely faster as we're no longer relying on JSDOM to pre-render pages - more robust - results will be closer to what the user sees This commit introduces a few breaking changes: - no need for the pre-build - `pageFilter` is replaced by `pages` - an array of urls to visit/screenshoot - `publicFolder` is now known as `outputDir` - which is more in line with the storybook plugin. A change was pushed to happo workers as part of testing this commit out. By default, the `history` API in the browser is mocked. This is done to prevent errors while running because a script navigated elsewhere. In the gatsby case however, we rely on replaceState and pushState. So I had to avoid mocking the history object for these types of runs.
Also remove the part about needing to pre-build now that building is part of the tool itself.
Also, make sure that the register call doesn't fail when happo isn't around.
This hasn't been required for quite some time.
The filter can be used to limit the number of pages compiled by gatsby. This can keep the build size and time down significantly.
This will help people discover this module.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make this plugin more robust and provide better screenshots, I'm switching approach a little. Instead of only using the precompiled (SSR) html files, I'm sending the whole static build over to happo workers and rendering things remotely.