-
Notifications
You must be signed in to change notification settings - Fork 631
add FD support to slcan according to CANable 2.0 impementation #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
fixed the black and ruff failings. |
Hi Bro, I have modify the code as your commit, send message is ok, but seems can not received message (windows platform), do you have this issue? |
Hello, Thank you for submitting this pull request. However, I noticed an issue regarding compatibility with classical devices that do not support CAN FD.
When using your branch, the initialization fails with the following exception:
In my opinion, the initialization should still work to support classical slcan devices. By the way, I tested the CAN FD capability with a 500k/2Mbps bus. Thank you. |
I agree my changes should not have that effect. I will update and check that useage. |
I send and receive without issue. I have found that ListenOnly mode doesn't work properly. I believe it is a canable firmware issue. |
Apologies for the delays. That fix is in to allow non-FD rates again and I believe this to be ready to merge. |
I confirmed that my issue has been resolved. Thank you for the update. |
The canable 2.0 project has extended the slcan interface to add support for CAN-FD frames and bitrate switching (see https://github.com/normaldotcom/canable2-fw). I needed this support for my work so I've implemented it in the library. If this work is useable I'd love to have it merged in. Happy to make tweaks or whatever, just need some direction.
Thank you for maintaining this project. It's immensely useful.