support pcapng file format #1936
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsseng
force-pushed
the
pcapng-io
branch
3 times, most recently
from
1a841c3 to
8d47c73
Compare
dsseng
commented
Apr 9, 2025
Comment on lines
+46
to
+48
| try: | ||
| import pyzstd | ||
| except ImportError: | ||
| pyzstd = None |
There was a problem hiding this comment.
Zstandard addition should be a distinct commit. Please let me know if you would like to merge with squashing so that I can split it out into a new PR
It is useful for both using SocketCAN devices and pcap(ng) files storing SocketCAN packets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Pcapng files to the I/O module
Related to #1403, pcap should be rather simple to implement based on these changes.
TODO:
lz4, zst, perhaps other compression types readers know about