Remove duplication of partitionKey that resulted in invalid json#2826
Closed
igvk wants to merge 3 commits intohardkoded:masterfrom
Closed
Remove duplication of partitionKey that resulted in invalid json#2826igvk wants to merge 3 commits intohardkoded:masterfrom
igvk wants to merge 3 commits intohardkoded:masterfrom
Conversation
Member
|
Do you wan to add some tests? |
Author
|
Yeah, it's a pity there are no tests on cookie partitioning. |
Member
At least testing the de/serialization |
Author
|
Here is the test of partition cookie |
kblok
added a commit
that referenced
this pull request
Feb 16, 2026
The CookiePartitionKeyConverter was writing PartitionKey as a plain string, but Chrome expects an object with topLevelSite and hasCrossSiteAncestor properties. This caused "Invalid cookie fields" errors when setting cookies with a partition key. Also adds the missing ShouldSetACookieWithAPartitionKey test from upstream. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 task
Member
|
Closing in favor of #3144 |
kblok
added a commit
that referenced
this pull request
Feb 18, 2026
* Fix CookiePartitionKey serialization and add partition key test (#2826) The CookiePartitionKeyConverter was writing PartitionKey as a plain string, but Chrome expects an object with topLevelSite and hasCrossSiteAncestor properties. This caused "Invalid cookie fields" errors when setting cookies with a partition key. Also adds the missing ShouldSetACookieWithAPartitionKey test from upstream. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Fix serialization test to expect object format for PartitionKey The converter now serializes PartitionKey as {topLevelSite, hasCrossSiteAncestor} object, so the test assertion needs to match. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> * Support partition key cookies in BiDi and fix Firefox compatibility - Remove the "BiDi only allows domain partition keys" exception for string partition keys, matching upstream Puppeteer behavior - Use StorageKeyPartitionDescriptor with sourceOrigin when a partition key is provided, BrowsingContextPartitionDescriptor otherwise - Extract goog:partitionKey and goog:sourceScheme from BiDi cookie extension data when reading cookies back - Make SourceScheme assertion Chrome-only since Firefox native BiDi doesn't include goog: extension properties - Add local test expectation to mark partition key test as FAIL on Firefox (native BiDi lacks goog:partitionKey) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cookies having Partition Keys are serialized incorrectly leading to errors when sending such cookies to the browser due to invalid json.