Use DNS for localnet. #4835
Use DNS for localnet. #4835
Conversation
|
With dns sync there is a txt dns request done to get the bootnode p2p information. I don't see how it will work here without a dns configured in this case. Looking at localnet ops we are https://github.com/harmony-one/harmony/blob/main/test/deploy.sh#L75 passing the bootnode info already in the harmony command line, that would explain why the Travis Ci test didn't fail. Was there any specific issue you were working on that led to that PR? |
|
without this PR you have to hardcode node addresses. Each command (debug, mult-bls) potentially have it's own set of nodes. I already mentioned that, here you can see the problem https://github.com/harmony-one/harmony/pull/4820/files#diff-65c92fad7c09270b02e7cb7b0d66f7a7a4145645cdea36a9061bb45c62e9670fR209 |
Frozen
force-pushed
the
feature/localnet-use-dns
branch
from
d160682 to
8584b70
Compare
|
Found issue with shard peer discovering, converted to draft |
Use DNS for localnet instead of
NewLocalSyncingPeerProvider