-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): add EOA sender validation (EIP-3607) #4840
Open
sunwavesun
wants to merge
13
commits into
harmony-one:feature/updated-mesage-struct-as-eth
Choose a base branch
from
sunwavesun:feat/eip3607
base: feature/updated-mesage-struct-as-eth
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(core): add EOA sender validation (EIP-3607) #4840
sunwavesun
wants to merge
13
commits into
harmony-one:feature/updated-mesage-struct-as-eth
from
sunwavesun:feat/eip3607
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sunwavesun
force-pushed
the
feat/eip3607
branch
from
January 31, 2025 06:31
df67d8a
to
1cd4c56
Compare
sunwavesun
force-pushed
the
feat/eip3607
branch
from
January 31, 2025 07:58
4d58519
to
eda4ea5
Compare
tests: set up function
sunwavesun
changed the title
EIP-3607 check if sender is EOA
feat(core): add EOA sender validation (EIP-3607)
Feb 2, 2025
sophoah
reviewed
Feb 4, 2025
sophoah
reviewed
Feb 4, 2025
Frozen
force-pushed
the
feature/updated-mesage-struct-as-eth
branch
from
February 4, 2025 23:44
16229ee
to
47fa42a
Compare
Frozen
force-pushed
the
feature/updated-mesage-struct-as-eth
branch
from
February 7, 2025 00:01
47fa42a
to
a815eaf
Compare
Hey @sunwavesun, I was checking rossetta tests for the #4840 and staking have been definitely broken inside it: Steps to reproduce - repo name in square brackets:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
preCheck
functionalityCause
This update enhances security by preventing contract accounts from sending transactions directly, aligning with the EIP-3607 standard. It addresses inconsistencies in sender validation logic within the core module.
How to Test
make go-test
to verify all unit tests passgo test -run ^TestPreCheck$ github.com/harmony-one/harmony/core
for the specific unit test