Prevent Explorer Nodes from Adding Future Blocks #4845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frozen
reviewed
Feb 10, 2025
node/harmony/node_explorer.go
Outdated
| if recvMsg.BlockNum != node.Blockchain().CurrentBlock().NumberU64()+1 { | ||
| utils.Logger().Warn(). | ||
| Uint64("Received BlockNum", recvMsg.BlockNum). | ||
| Uint64("Consensus BlockNum", node.GetConsensusBlockNum()). |
There was a problem hiding this comment.
Explorer node does not participate in consensus, so getting consensus block number doesn't make much sense for me
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that explorer nodes do not accept future blocks that are not the immediate next block during the COMMIT and PREPARE phase. Previously, there was no strict check on whether a received block was sequential, which could lead to inconsistencies.