Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default for additional security group param #852

Open
wants to merge 2 commits into
base: next
Choose a base branch
from
Open

add default for additional security group param #852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc248d3
add default for additional security group param
rishi-gajula-harrys Jul 17, 2023
eb360a2
specify security group
rishi-gajula-harrys Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudformation/do_cloudformation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ case "$DW_VERB" in
--stack-name "$STACK_NAME" \
--template-body "$TEMPLATE_URI" \
--on-failure DO_NOTHING \
--capabilities CAPABILITY_NAMED_IAM \
--capabilities CAPABILITY_NAMED_IAM CAPABILITY_AUTO_EXPAND \
--parameters $STACK_PARAMETERS \
--tags \
"Key=user:project,Value=data-warehouse" \
Expand Down
8 changes: 2 additions & 6 deletions cloudformation/dw_cluster.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,9 +96,6 @@ Parameters:
- Delete
- Retain
Default: Delete
AdditionalSecurityGroupParam:
Description: Add security group
Type: String
Environment:
Description: specify env dev or prod
Type: String
Expand Down Expand Up @@ -169,7 +166,7 @@ Resources:
- ParameterName: "search_path"
ParameterValue: "$user, public"
- ParameterName: "statement_timeout"
ParameterValue: 0
ParameterValue: 7200000
- ParameterName: "wlm_json_configuration"
ParameterValue: !Sub "[{ \"query_concurrency\": ${QueryConcurrency} }]"
Tags:
Expand Down Expand Up @@ -225,8 +222,7 @@ Resources:
PreferredMaintenanceWindow:
!Ref PreferredMaintenanceWindow
VpcSecurityGroupIds:
- Fn::ImportValue: !Sub "${VpcStackName}::redshift-public-sg"
- !Ref AdditionalSecurityGroupParam
- sg-eff0db9c
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a public repo. I wouldn't hard-code security groups.

SnapshotIdentifier:
!If [ "HasSnapshotIdentifier", !Ref "SnapshotIdentifier", !Ref "AWS::NoValue" ]
Tags:
Expand Down