charts: add LVM VolumeSnapshotClass as default #302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vicente-Cheng
force-pushed
the
add-lvm-snapshotclass
branch
from
7496d9a to
da88482
Compare
bk201
approved these changes
Oct 9, 2024
Signed-off-by: Vicente Cheng <[email protected]>
Vicente-Cheng
force-pushed
the
add-lvm-snapshotclass
branch
from
da88482 to
df9e714
Compare
WebberHuang1118
approved these changes
Oct 9, 2024
|
I am checking the lint error. Not sure why it always happened. |
- to make lint happy for lvm volumesnapshotclass.yaml
- bump kind-action to v1.10.0
Signed-off-by: Vicente Cheng <[email protected]>
Vicente-Cheng
force-pushed
the
add-lvm-snapshotclass
branch
from
390d187 to
936cc84
Compare
|
Now, it's ready! Thanks @bk201 for finding this one! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need LVM
VolumeSnapshotClassbecause our LVM csi driver supports volume snapshot