Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] Add virtualmachines to harvester-network-webhook rbac #341

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

w13915984028
Copy link
Member

Backport PR to release of original PR #339

For PR Check vm when a NAD is deleted
harvester/network-controller-harvester#149
harvester/network-controller-harvester#131

Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to bump the chart version?

@w13915984028
Copy link
Member Author

w13915984028 commented Mar 4, 2025

@starbops @mingshuoqiu PR also sets chart version to v1.5.0-dev.1, thanks.

There was a pending PR https://github.com//pull/321, which plans to bump to v0.6.0. Per the latest plan, do we plan to bump it to `v1.5.0-dev.0` ? PR 341 will then on top of them, or PR341 first, and another PR later. Any plan for `v1.5.0-*` version? thanks.

 Check vm when a NAD is deleted

Signed-off-by: Jian Wang <[email protected]>
Copy link
Member

@starbops starbops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@w13915984028 w13915984028 requested a review from bk201 March 6, 2025 09:14
@w13915984028 w13915984028 merged commit 9c8e026 into harvester:release Mar 6, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants