-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump go to v1.23.4 #48
Conversation
@mergify backport v1.5 |
✅ Backports have been created
|
Signed-off-by: Jian Wang <[email protected]>
d28381f
to
96e07f1
Compare
@FrankYang0529 Please take a new look, the golang lint gosec error is escaped now. thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Just a small nit that may be an oversight or may be nothing.
@@ -1,11 +1,11 @@ | |||
FROM registry.suse.com/bci/golang:1.22.8 | |||
FROM registry.suse.com/bci/golang:1.23 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be pinned to 1.23.4?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From other related PRs, seems bci base image is 1.23 now, it may be slightly different with go version itself
harvester/harvester#7336