Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go to v1.23.4 #48

Merged
merged 1 commit into from
Feb 14, 2025
Merged

Bump go to v1.23.4 #48

merged 1 commit into from
Feb 14, 2025

Conversation

w13915984028
Copy link
Member

@w13915984028
Copy link
Member Author

@mergify backport v1.5

Copy link

mergify bot commented Feb 14, 2025

backport v1.5

✅ Backports have been created

Signed-off-by: Jian Wang <[email protected]>
@w13915984028
Copy link
Member Author

@FrankYang0529 Please take a new look, the golang lint gosec error is escaped now. thanks.

Copy link

@m-ildefons m-ildefons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just a small nit that may be an oversight or may be nothing.

@@ -1,11 +1,11 @@
FROM registry.suse.com/bci/golang:1.22.8
FROM registry.suse.com/bci/golang:1.23

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be pinned to 1.23.4?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From other related PRs, seems bci base image is 1.23 now, it may be slightly different with go version itself

https://github.com/rancher/support-bundle-kit/pull/132/files#diff-3598233dce47ce9c207a77a9f23394d45235397dd66d7dd9de909487e1bd8e8aL1

@w13915984028 w13915984028 merged commit 568d639 into harvester:master Feb 14, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants