Add resource identity to Move RPC

[rainkwan]

Follow-Up PR for #1112

This PR implements MoveResourceState (Move) for identity.

[austinvalle]

Overall everything is looking good! I had a couple questions/nits

[austinvalle]

nit - Neither of these tests use an identitySchema, which is technically valid for this unit test, but not valid in general 😄 (same note for the fromproto6 tests)

Example:

• terraform-plugin-framework/internal/fromproto5/importresourcestate_test.go

  Lines 51 to 57 in db08a72

  	testIdentitySchema := identityschema.Schema{
  	Attributes: map[string]identityschema.Attribute{
  	"test_identity_attribute": identityschema.StringAttribute{
  	RequiredForImport: true,
  	},
  	},
  	}

• terraform-plugin-framework/internal/fromproto5/importresourcestate_test.go

  Lines 115 to 131 in db08a72

  	"identity": {
  	input: &tfprotov5.ImportResourceStateRequest{
  	Identity: &tfprotov5.ResourceIdentityData{
  	IdentityData: &testIdentityProto5DynamicValue,
  	},
  	},
  	resourceSchema: testFwSchema,
  	identitySchema: testIdentitySchema,
  	expected: &fwserver.ImportResourceStateRequest{
  	EmptyState: testFwEmptyState,
  	IdentitySchema: testIdentitySchema,
  	Identity: &tfsdk.ResourceIdentity{
  	Raw: testIdentityProto5Value,
  	Schema: testIdentitySchema,
  	},
  	},
  	},

[austinvalle]

Were you meaning to update this diagnostic with the source identity information? If so, you'll just need to make sure you only print something if we actually receive a source identity.

I think core will always store 0 for the identity schema version in state regardless of it the resource supports identity, so we might want to check SourceIdentity for that

[austinvalle]

nit - Since we have the logic checking for an invalid identity response, we should consider adding a small test for it 👍🏻

Example:

terraform-plugin-framework/internal/fwserver/server_readresource_test.go

Lines 662 to 690 in db08a72

	"response-invalid-identity": {
	server: &fwserver.Server{
	Provider: &testprovider.Provider{},
	},
	request: &fwserver.ReadResourceRequest{
	CurrentState: testCurrentState,
	Resource: &testprovider.Resource{
	ReadMethod: func(ctx context.Context, req resource.ReadRequest, resp *resource.ReadResponse) {
	// This resource doesn't indicate identity support (via a schema), so this should raise a diagnostic.
	resp.Identity = &tfsdk.ResourceIdentity{
	Raw: testNewIdentityValue,
	Schema: testIdentitySchema,
	}
	},
	},
	},
	expectedResponse: &fwserver.ReadResourceResponse{
	Diagnostics: diag.Diagnostics{
	diag.NewErrorDiagnostic(
	"Unexpected Read Response",
	"An unexpected error was encountered when creating the read response. New identity data was returned by the provider read operation, but the resource does not indicate identity support.\n\n"+
	"This is always a problem with the provider and should be reported to the provider developer.",
	),
	},
	NewState: testCurrentState,
	NewIdentity: testNewIdentity,
	Private: testEmptyPrivate,
	},
	},

[austinvalle]

Is this something you ran into specifically? I would expect this to never happen 🤔

[austinvalle]

Suggested change

	// SourceIdentitySchemaVersion is the version of the source resource state.
	// SourceIdentitySchemaVersion is the version of the source resource identity.