Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FourPointOh - clean up remaining usages #28655

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

sreallymatt
Copy link
Collaborator

@sreallymatt sreallymatt commented Jan 31, 2025

Community Note

  • Please vote on this PR by adding a 👍 reaction to the original PR to help the community and maintainers prioritize for review
  • Please do not leave comments along the lines of "+1", "me too" or "any updates", they generate extra noise for PR followers and do not help prioritize for review

Description

Clean up the remaining FourPointOh(Beta) flag usages and remove the feature entirely.

PR Checklist

  • I have followed the guidelines in our Contributing Documentation.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • I have checked if my changes close any open issues. If so please include appropriate closing keywords below.
  • I have updated/added Documentation as required written in a helpful and kind way to assist users that may be unfamiliar with the resource / data source.
  • I have used a meaningful PR title to help maintainers and other users understand this change and help prevent duplicate work.
    For example: “resource_name_here - description of change e.g. adding property new_property_name_here

Testing

  • My submission includes Test coverage as described in the Contribution Guide and the tests pass. (if this is not possible for any reason, please include details of why you did or could not add test coverage)

App Service:
image
Checked all new failures, 409s, 429s and resource group quota exceeded...

Automation:
image

Container Apps:
image

New test failures:
1 due to exceeding resource group quota
The other:

Status: "Failed"
Code: "ManagedEnvironmentProvisioningError"
Message: "Error when initializing components on ManagedCluster Error running
Helm upgrade --install k8se ./k8se --namespace k8se-system --create-namespace
--set containerAppController.enableDefaultProbeForConsumptionV2=true --values
C:\\local\\Temp\\tmptinwnx.tmp\r\noutput: \r\n\r\nerror: Error: UPGRADE
FAILED: \"k8se\" has no deployed releases\r\n\r\n"
Activity Id: ""

Nginx Deployment:
image

Recovery Services:
image
1 new failure:

Status: "35022"
Code: ""
Message: "'acctest-protection-cont2-250204231855133369' cannot be deleted."
Activity Id: ""

Storage Table Entities data source:
image

This is a (please select all that apply):

  • Bug Fix
  • New Feature (ie adding a service, resource, or data source)
  • Enhancement
  • Breaking Change

Note

If this PR changes meaningfully during the course of review please update the title and description as required.

katbyte
katbyte previously approved these changes Jan 31, 2025
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ⛈️

@sreallymatt
Copy link
Collaborator Author

Encountered a panic due to the change in resource_decode.go and the removedInNextMajorVersion tag. Do not merge yet

@sreallymatt sreallymatt changed the title FourPointOh - clean up remaining usages [DO NOT MERGE] FourPointOh - clean up remaining usages Jan 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants