actions can not be used in depends_on #37781
Open
+84
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielMSchmidt
added
no-changelog-needed
DanielMSchmidt
force-pushed
the
fix-actions-in-depends-on
branch
from
ef7e7ff to
89f5a33
Compare
mildwonkey
reviewed
Oct 16, 2025
| // We don't allow depends_on on actions because their ordering is depending on the resource | ||
| // that triggers them, therefore users should use a depends_on on the resource instead. | ||
|
|
||
| if ref != nil { |
There was a problem hiding this comment.
Are we checking for this during configload? I certainly didn't add anything to the resource so (if it's isn't there already) we may be able to return an error if a resource's depends_on isn't referring to an action sooner than the graph walk.
mildwonkey
approved these changes
Oct 16, 2025
matejrisek
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37780
Target Release
1.14.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry