Fix TSL host mismatch#32014
Closed
coleheinbaugh wants to merge 1 commit into
Closed
Conversation
…en on the dynamic leaf cert
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/concepts/projects/project-configuration |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
CI Results: |
Contributor
Author
|
This PR should have been opened in Vault-Enterprise, so it has been moved there: https://github.com/hashicorp/vault-enterprise/pull/15813 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the TSL host mismatch by manually setting the TSL server name in
TestSelfSignedCAto match what is given by the new dynamic leaf cert generator.In commit c814860 we start using dynamic leaf certs, that have the server name of
local hostas opposed to the old cert this test would get which allowed for server namelocal hostandcassandra.TODO only if you're a HashiCorp employee
backport/label that matches the desired release branch.PCI review checklist
Examples of changes to security controls include using new access control methods, adding or removing logging pipelines, etc.