audit: Fix missing request ID in audit log for help operations#32025
Open
Flamefire wants to merge 3 commits into
Open
audit: Fix missing request ID in audit log for help operations#32025Flamefire wants to merge 3 commits into
Flamefire wants to merge 3 commits into
Conversation
dosubot
Bot
added
the
size:XS
|
Deployment failed with the following error: Learn More: https://vercel.com/docs/concepts/projects/project-configuration |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
|
|
Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement Learn more about why HashiCorp requires a CLA and what the CLA includes Have you signed the CLA already but the status is still pending? Recheck it. |
dosubot
Bot
added
size:S
The handleHelp function in http/help.go didn't set an ID unlike all other handlers. This caused the request.id field to be silently omitted from audit log entries for all help operations (e.g. `vault path-help`), making it impossible to correlate request and response entries in the audit log.
Flamefire
force-pushed
the
fix/help-audit-request-id
branch
from
194339b to
f24ffd4
Compare
Contributor
|
Hi there! Thanks for this fix. Please sign the CLA and ping me when that's done, so I can get this in front of engineers for review. :) |
Author
|
@heatherezell Thought that went through already, done now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The handleHelp function in http/help.go didn't set an ID unlike all other handlers.
This caused the request.id field to be silently omitted from audit log entries for all
help operations (e.g.
vault path-help), making it impossible to correlate request and response entries in the audit log.Fix this by setting that ID
Fixes #32026