Consistently rename ciphertext-related types and functions in sel #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intricate
commented
Feb 17, 2025
intricate
commented
Feb 17, 2025
|
Since this a breaking change of the API, could you introduce a changelog entry (https://github.com/haskell-cryptography/libsodium-bindings/blob/main/sel/CHANGELOG.md) for v0.1.0.0 ? And bump the version in |
intricate
force-pushed
the
rename-sel-secretkey-cipher-hash
branch
from
669f2d6 to
a9159e8
Compare
intricate
force-pushed
the
rename-sel-secretkey-cipher-hash
branch
from
a9159e8 to
2b97374
Compare
intricate
force-pushed
the
rename-sel-secretkey-cipher-hash
branch
from
2b97374 to
2b7b18d
Compare
intricate
changed the title
intricate
force-pushed
the
rename-sel-secretkey-cipher-hash
branch
3 times, most recently
from
0153e72 to
b09a7ff
Compare
|
hi all, not to be a bother, but I just wanted to check in on this 😁 |
|
@intricate thanks, I'm on it. :) |
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
Kleidukos
force-pushed
the
rename-sel-secretkey-cipher-hash
branch
from
b09a7ff to
7c1f238
Compare
Kleidukos
approved these changes
Mar 21, 2025
There was a problem hiding this comment.
@intricate Thank you for your patience! This is excellent work and I'm really honoured you felt that this project was worth contributing to. 🙇
|
@Kleidukos: No problem at all. Happy to help out and continue contributing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #181