Skip to content

Fix issue with inability to parse mandatory types #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix issue with inability to parse mandatory types #222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
90a5d7b
Fix issue with inability to parse mandatory types
fredefox Aug 7, 2019
22e31b5
Enable language extensions by default
fredefox Aug 12, 2019
4273aad
Increase test coverage tolerance
fredefox Aug 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions package.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@ extra-source-files:
# NB the "redundant constraints" warning is a GHC bug: https://ghc.haskell.org/trac/ghc/ticket/11099
ghc-options: -Wall -fno-warn-redundant-constraints
default-extensions:
- DerivingStrategies
- NoImplicitPrelude
- OverloadedStrings
- RecordWildCards
- StandaloneDeriving
- TypeApplications

dependencies:
Expand Down
2 changes: 1 addition & 1 deletion scripts/hpc-ratchet
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Each item represents the number of "things" we are OK with not being covered.
COVERAGE_TOLERANCE = {
ALTERNATIVES: 154,
BOOLEANS: 8,
EXPRESSIONS: 1366,
EXPRESSIONS: 1367,
LOCAL_DECLS: 10,
TOP_LEVEL_DECLS: 673,
}
Expand Down
4 changes: 2 additions & 2 deletions src/GraphQL/Internal/Syntax/Parser.hs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,8 +212,8 @@ directive = AST.Directive
-- * Type Reference

type_ :: Parser AST.GType
type_ = AST.TypeList <$> listType
<|> AST.TypeNonNull <$> nonNullType
type_ = AST.TypeNonNull <$> nonNullType
<|> AST.TypeList <$> listType
<|> AST.TypeNamed <$> namedType
<?> "type_ error!"

Expand Down