Skip to content

Tweak Array.deleteM #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Tweak Array.deleteM #360

wants to merge 1 commit into from

Conversation

sjakobi
Copy link
Member

@sjakobi sjakobi commented Mar 2, 2022

TODO:

  • Check performance implications

@sjakobi
Copy link
Member Author

sjakobi commented Mar 2, 2022

FYI @treeowl: I had accidentally pushed this change directly to master (I have reverted it since). To prevent similar or worse accidents, and because I like to know what's changing on master, I have created a branch protection rule that requires any change to master to go through a PR. See https://github.com/haskell-unordered-containers/unordered-containers/settings/branches.

If this causes any problems for you, or if you would prefer different branch protections, please let me know. :)

@sjakobi sjakobi force-pushed the sjakobi/tweak-deletem branch from 71bfd61 to f013ce9 Compare March 2, 2022 23:02
@sjakobi
Copy link
Member Author

sjakobi commented Mar 2, 2022

Somehow this patch seems to massively increase the noise level in the benchmarks. And as far as I can tell the numbers aren't better either. Maybe worth revisiting once we have a solution for #332, maybe not.

@sjakobi sjakobi closed this Mar 2, 2022
@sjakobi sjakobi deleted the sjakobi/tweak-deletem branch March 2, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sjakobi