Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Narrow ghc mod core #1255

Merged
merged 10 commits into from
May 12, 2019
Merged

Narrow ghc mod core #1255

merged 10 commits into from
May 12, 2019

Conversation

alanz
Copy link
Collaborator

@alanz alanz commented May 11, 2019

Since ghc-mod is going to be deprecated soon, and replaced by some new shiny thing as part of @DanielG 's GSOC, this patch attempts to help the process by slimming down and documenting the actual parts of ghc-mod currently used by hie.

@alanz alanz requested review from lukel97, wz1000 and fendor May 11, 2019 16:33
@@ -134,6 +123,7 @@ typeCmd :: CommandFunc TypeParams [(Range,T.Text)]
typeCmd = CmdSync $ \(TP _bool uri pos) ->
liftToGhc $ newTypeCmd pos uri

-- AZ: currently only used in tests, but
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but what?

@alanz alanz merged commit 6254c09 into haskell:master May 12, 2019
@alanz alanz deleted the narrow-ghc-mod-core branch May 12, 2019 16:39
@alanz alanz added this to the 2019-05 milestone Jun 1, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants