You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Oct 7, 2020. It is now read-only.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hie does not compile with earlier versions of hlint, so I bumped the version in the cabal file instead of stack file. I did not touch stack-8.2.2.yaml though it seems that build is broken anyway. As a bonus the whole thing builds with cabal v2-build.
I am not sure this change can succeed. If you force the version in haskell-ide-engine.cabal to be ==2.2.2, how could hie-8.2.2 still be built, since it uses the same cabal file and doesnt work with hlint == 2.2.2?
Thus, the version range of the cabal file, or am I overlooking something here?
My change was a bit premature indeed... I initially thought the ghc-8.2 would fail regardless because https://github.com/haskell/haskell-ide-engine/blob/master/src/Haskell/Ide/Engine/Plugin/ApplyRefact.hs
imports HLint4. I see now that it is conditional depending on the version of ghc. My cabal build was failing with 2.1.22 because of the same issue. Okay, so the problem I was trying to solve is failing builds with ghc-8.4 and above using old hlint. I think my next commit(ac627d0) should properly solve it.
LinuxUser404
changed the title
bumped hlint to 2.2.2
Made hlint dependency properly depend on version of ghc.
Aug 6, 2019
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LinuxUser404
changed the title
hie does not compile with earlier versions of hlint, so I bumped the version in the cabal file instead of stack file. I did not touch stack-8.2.2.yaml though it seems that build is broken anyway. As a bonus the whole thing builds with cabal v2-build.