Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Pass Ormolu cradle flags & default-extensions #1589

Merged
merged 12 commits into from
Jan 25, 2020

Conversation

Avi-D-coder
Copy link
Collaborator

Take 2

@Avi-D-coder Avi-D-coder requested review from lukel97 and fendor January 22, 2020 00:06
@fendor
Copy link
Collaborator

fendor commented Jan 23, 2020

@Avi-D-coder Shall we wait for an hie-bios release before merging this?

@Avi-D-coder
Copy link
Collaborator Author

@fendor When is the next hie-bios release planed? I would like to get this pr in today, so I can send in ormolu 0.0.3.1 and range formats on top of it and only have to rebase once. If hie-bios needs more time I would prefer to temporarily add the initializeFlagsWithCradleWithMessage and remove it when hie-bios is updated.

@fendor
Copy link
Collaborator

fendor commented Jan 23, 2020

I would plan to update hie-bios before the HIE release, if possible. However, adressing the remaining issue, then merging and creating an issue is fine for me

@alanz
Copy link
Collaborator

alanz commented Jan 23, 2020

When is the next hie-bios release planed?

Probably the weekend of 1 Feb


data GhcModuleCache = GhcModuleCache
{ cradleCache :: !(T.Trie CachedCradle)
-- ^ map from FilePath to cradles
-- May not include currentCradle
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? The cradle cache should also contain current cradle, no?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea, I added this as a warning, because I had expected it to be in the cache.

Comment on lines +123 to +132
data CachedCradle = CachedCradle
{ ccradle :: BIOS.Cradle
, hscEnv :: HscEnv
, compOpts :: BIOS.ComponentOptions
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are already at it, could you extend documentation for this, too?

@Avi-D-coder
Copy link
Collaborator Author

Can someone who uses cabal tell me why its not trying ormolu-0.0.3.1?

Resolving dependencies...
cabal: Could not resolve dependencies:
[__0] trying: haskell-ide-engine-1.0.0.0 (user goal)
[__1] next goal: ormolu (dependency of haskell-ide-engine)
[__1] rejecting: ormolu-0.0.3.0, ormolu-0.0.2.0, ormolu-0.0.1.0 (conflict:
haskell-ide-engine => ormolu>=0.0.3.1)
[__1] fail (backjumping, conflict set: haskell-ide-engine, ormolu)
After searching the rest of the dependency tree exhaustively, these were the
goals I've had most trouble fulfilling: haskell-ide-engine, ormolu

@fendor
Copy link
Collaborator

fendor commented Jan 24, 2020

@Avi-D-coder maybe you need to update your hackage index, e.g. cabal v2-update?

@Avi-D-coder
Copy link
Collaborator Author

@fendor no luck both on circleci and locally

cabal v2-clean
cabal v2-update
cabal v2-configure 

@Avi-D-coder Avi-D-coder requested a review from fendor January 24, 2020 16:59
@fendor
Copy link
Collaborator

fendor commented Jan 24, 2020

Last remark :)

Co-Authored-By: fendor <[email protected]>
@Avi-D-coder
Copy link
Collaborator Author

Anyone else have a objection before CI finishes and I merge?

@Avi-D-coder
Copy link
Collaborator Author

All the azure errors are unrelated.

@Avi-D-coder Avi-D-coder merged commit 7fa1382 into haskell:master Jan 25, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants