-
Notifications
You must be signed in to change notification settings - Fork 206
Pass Ormolu cradle flags & default-extensions #1589
Conversation
385008b
to
ff880e0
Compare
@Avi-D-coder Shall we wait for an hie-bios release before merging this? |
@fendor When is the next hie-bios release planed? I would like to get this pr in today, so I can send in ormolu 0.0.3.1 and range formats on top of it and only have to rebase once. If hie-bios needs more time I would prefer to temporarily add the |
I would plan to update hie-bios before the HIE release, if possible. However, adressing the remaining issue, then merging and creating an issue is fine for me |
Probably the weekend of 1 Feb |
701bde1
to
cea6f0f
Compare
|
||
data GhcModuleCache = GhcModuleCache | ||
{ cradleCache :: !(T.Trie CachedCradle) | ||
-- ^ map from FilePath to cradles | ||
-- May not include currentCradle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not? The cradle cache should also contain current cradle, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, I added this as a warning, because I had expected it to be in the cache.
data CachedCradle = CachedCradle | ||
{ ccradle :: BIOS.Cradle | ||
, hscEnv :: HscEnv | ||
, compOpts :: BIOS.ComponentOptions | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are already at it, could you extend documentation for this, too?
5664e9f
to
0725e86
Compare
Can someone who uses cabal tell me why its not trying
|
@Avi-D-coder maybe you need to update your hackage index, e.g. |
@fendor no luck both on circleci and locally
|
Last remark :) |
Co-Authored-By: fendor <[email protected]>
Anyone else have a objection before CI finishes and I merge? |
All the azure errors are unrelated. |
Take 2