This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Fix error message parsing to import types #1597
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix error message parsing to enable HsImport plugin to import Types. Moreover, fix generation of Code Actions to avoid cases where the same Code Action was displayed multiple times.
fendor
force-pushed
the
hsimport-types
branch
from
98d12aa to
23bc8e8
Compare
Avi-D-coder
approved these changes
Jan 25, 2020
lukel97
approved these changes
Jan 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix error message parsing to enable HsImport plugin to import Types.
Moreover, fix generation of Code Actions to avoid cases
where the same Code Action was displayed multiple times.
Overall tests for HsImport actions are lacking. This problem flew under the radar since I initially wrote the feature of import-lists.