Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Add 8.8.2 stack file and CI #1607

Merged
merged 8 commits into from
Jan 27, 2020
Merged

Add 8.8.2 stack file and CI #1607

merged 8 commits into from
Jan 27, 2020

Conversation

lukel97
Copy link
Collaborator

@lukel97 lukel97 commented Jan 26, 2020

No description provided.

@lukel97 lukel97 requested review from jneira, alanz and fendor January 26, 2020 15:28
Copy link
Collaborator

@alanz alanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukel97 lukel97 mentioned this pull request Jan 26, 2020
Copy link
Collaborator

@fendor fendor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, is Azure CI missing?

@Avi-D-coder
Copy link
Collaborator

@jneira is 8.8.2 working on windows?

@lukel97
Copy link
Collaborator Author

lukel97 commented Jan 26, 2020

Actually, is Azure CI missing?

I'm not familiar with the Azure stuff, can you or @jneira handle this afterwards?

@jneira
Copy link
Member

jneira commented Jan 26, 2020

@Avi-D-coder last time i tried with cabal i hit a compilation error involving haddock-api but i'll try again
The pr already has a workaround

jneira
jneira previously approved these changes Jan 26, 2020
@jneira
Copy link
Member

jneira commented Jan 26, 2020

Lot of test errors with ghc-8.2.2, are they present in local tests?

@jneira
Copy link
Member

jneira commented Jan 26, 2020

Trying with cabal after adding

source-repository-package
    type: git
    location: https://github.com/haskell/haddock.git
    subdir: haddock-api
    tag: be8b02c4e3cffe7d45b3dad0a0f071d35a274d65

in cabal.project

@jneira
Copy link
Member

jneira commented Jan 27, 2020

I am getting this compile error in windows using stack:

ormolu               > D:\sr\snapshots\f5723ebd\lib\x86_64-windows-ghc-8.8.2\ghc-lib-parser-8.8.2-75ZOMeqOpqa23xhx9rJVRy\HSghc-lib-parser-8.8.2-75ZOMeqOpqa23xhx9rJVRy.o: unhandled PEi386 relocation type 0
ormolu               > ghc.exe: unable to load package `ghc-lib-parser-8.8.2'
......
--  While building package ormolu-0.0.3.1 using:
      D:\sr\setup-exe-cache\x86_64-windows\Cabal-simple_Z6RU0evB_3.0.1.0_ghc-8.8.2.exe --builddir=.stack-work\dist\29cc6475 build --ghc-options ""
    Process exited with code: ExitFailure 1

I've added ghc-8.8.2 to azure anyway

@jneira jneira self-requested a review January 27, 2020 09:29
@jneira
Copy link
Member

jneira commented Jan 27, 2020

The fix for windows to be able to build Cabal was not included in ghc-8.8.2, it has been backported to 8.8.3 😭

I am getting the same error for windows building it with cabal than ghc-8.8.1:

ghc.exe: unable to load package `Cabal-3.0.1.0'
ghc.exe:  | D:\Trabajo\NO-SALVAR\jneira\bin\Programs\stack\x86_64-windows\ghc-8.8.2\lib\Cabal-3.0.1.0\HSCabal-3.0.1.0.o: unknown symbol `.file'
cabal.exe: Failed to build lib:c-h-internal from cabal-helper-1.0.0.0 (which
is required by test:wrapper-test from haskell-ide-engine-1.0.0.0,
test:unit-test from haskell-ide-engine-1.0.0.0 and others). See the build log
above for details.

So i have to remove this version from windows too 😞

@jneira jneira dismissed their stale review January 27, 2020 10:35

Revise tests results in circleci

@lukel97
Copy link
Collaborator Author

lukel97 commented Jan 27, 2020

The linux CircleCI tests were failing because I forgot to update the testutils with the new version, committing that fix now

The fix for windows to be able to build Cabal was not included in ghc-8.8.2, it has been backported to 8.8.3 😭

Argh, c'est la vie.

@lukel97 lukel97 merged commit 535d482 into master Jan 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants