This repository was archived by the owner on Oct 7, 2020. It is now read-only.
Deduplicate main for hie/hie-wrapper #1610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure how to merge the CPP'd imports. Note that hie-wrapper now partakes of the hSetBuffer stderr LineBuffering and the "hie-bios".
fendor
reviewed
Jan 27, 2020
| @@ -15,6 +29,27 @@ data GlobalOpts = GlobalOpts | |||
| , optFiles :: [FilePath] | |||
| } deriving (Show) | |||
|
|
|||
| initApp :: String -> IO GlobalOpts | |||
There was a problem hiding this comment.
Since this is now happening out of context, it would be nice if there was some documentation what this function does, e.g. initialises logger, searches for some project root, etc...
There was a problem hiding this comment.
Maybe instead reestablish context, such as by saying in a comment that this is the common prefix of hie and hie-wrapper?
There was a problem hiding this comment.
Yeah, that makes sense, too. Still, what it roughly does to set-up the application would be nice as well.
jneira
approved these changes
Jan 29, 2020
fendor
approved these changes
Jan 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure how to merge the CPP'd imports.
Note that hie-wrapper now partakes of the hSetBuffer stderr LineBuffering
and the "hie-bios".