Skip to content
This repository was archived by the owner on Oct 7, 2020. It is now read-only.

Make install script use unix-time-0.4.7 #1715

Merged
merged 1 commit into from
Mar 29, 2020

Conversation

jneira
Copy link
Member

@jneira jneira commented Mar 28, 2020

@jneira jneira merged commit b7fd5fb into haskell:master Mar 29, 2020
@jneira jneira deleted the fix-install-hoogle branch March 29, 2020 17:40
@mouse07410
Copy link

@jneira is there a reason why you're using resolver 13.19, rather than 15.6 or at least 14.27?

FWIW, I seem to be able to build the master branch successfully using resolver 15.6 in install/shake.yaml.

@jneira
Copy link
Member Author

jneira commented Apr 2, 2020

No other than match the most used resolver/ghc to try download only one ghc and keep one stack cache. The "most used" ghc is not exact but, f.e. in windows ghc-8.8.* still has bugs and ghc-8.10 is not supported yet.

@mouse07410
Copy link

@jneira I'm confused.

On one hand, HIE must be built by the same GHC that it would serve, or there could/would be problems.

On the other hand, you're freezing install/shake.yaml at the older GHC-8.6.5 LTS resolver - and not even the current GHC-8.6.5 LTS resolver (which is 14.27).

I can understand why not lts-15.6. But why not lts-14.27?

And how does it (or why it doesn't) impact building HIE with/for GHC-8.8.3 (e.g., on Mac and Linux)?

And yeah, I understand about 8.10.1. :-(

@jneira
Copy link
Member Author

jneira commented Apr 3, 2020

I think maybe it is a little bit clear in #1712 (comment)

But yeah, it could use the last lts for each ghc version. At the end it is a (relatively small) script and it works so we did no take care of so much.

@mouse07410
Copy link

@jneira I hear you, thanks.

I'd still suggest bringing the resolver to lts-14.27 if you intend this script to stay with GHC-8.6.5, or to lts-15.6 if you're to move to GHC-8.8.3.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ghc.exe: unable to load package "unix-time-0.4.5" unknown symbol "_create_locale". ExitFailure 1
3 participants