-
Notifications
You must be signed in to change notification settings - Fork 206
Use installed ghc in stack linux builds #1737
Conversation
To avoid download it again and not waste disk space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I am afraid that the actual configuration is not valid for wrapper-test, cause it assumes that stack will have the correct ghc downloaded or in path. It needs up to two different ghcs (ghc-8.8.1 and ghc-8.6.5) so not sure if it will be enough space for both although we are not downloading the main one, the used to build everything else. |
How about we mock the wrapper tests? You think that is possible? |
Idea for test-mocking:
|
Mmm, interesting, but stack with In fact, we have the real ghcs! so we could point to the appropiate one for each test. Not pretty, though 🤔 |
I was wrong, stack picks a ghc-${version} in path if it needs it so the solution is simpler than i thought: we can set in path the needed ghcs, putting the main one in first place |
Ok, the stack linux jobs that has not failed due to the response timeout are successful now, so i think the pr could be merged |
stack exec hoogle generate
: see Timeouts downloading cabal.config's from stackage in azure ci ndmitchell/hoogle#347