Skip to content

Enhance/releasing checklist #3781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 1, 2023
Merged

Enhance/releasing checklist #3781

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5db7059
Add supported table in GHCup instructions
fendor Aug 28, 2023
172dd07
Update ghc-version-support table
fendor Aug 29, 2023
f7f1d2f
Merge branch 'master' into enhance/releasing-checklist
michaelpj Aug 29, 2023
ea20097
Merge branch 'master' into enhance/releasing-checklist
michaelpj Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions RELEASING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,5 +57,9 @@
- [ ] upload hackage packages
- requires credentials
- [ ] update https://haskell-language-server.readthedocs.io/en/latest/support/ghc-version-support.html#current-ghc-version-support-status
- [ ] Supported tools table needs to be updated:
- https://www.haskell.org/ghcup/install/#supported-platforms
- https://github.com/haskell/ghcup-hs/blob/master/docs/install.md#supported-platforms
- https://github.com/haskell/ghcup-metadata/blob/44c6e2b5d0fcae15abeffff03e87544edf76dd7a/ghcup-gen/Main.hs#L67
- [ ] post release on discourse and reddit
- [ ] merge release PR to master or forward port relevant changes
1 change: 1 addition & 0 deletions docs/support/ghc-version-support.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ Support status (see the support policy below for more details):
|--------------|--------------------------------------------------------------------------------------|-----------------------------------------------------------------------------|
| 9.6.2 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | basic support |
| 9.6.1 | [2.0.0.0](https://github.com/haskell/haskell-language-server/releases/tag/2.0.0.0) | basic support |
| 9.4.7 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
| 9.4.6 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
| 9.4.5 | [latest](https://github.com/haskell/haskell-language-server/releases/latest) | full support |
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the entries for 9.4.5 and 9.4.6 are wrong also? They should say the last supported version was something previous.

Copy link
Collaborator Author

@fendor fendor Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We ship binaries for 9.4.6 and 9.4.5 with the 2.2.0.0 release as well, so the table is accurate afaict

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I missed that. I thought the policy was to only ship binaries for the last minor release of each major release?

Copy link
Collaborator Author

@fendor fendor Aug 29, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, yeah, that's true, too.

I thought it would be better to ship binaries for these two older minor releases as well, so people don't have to upgrade immediately, don't invalidate their entire cabal store for a minor release, but still get an updated HLS version. There was no additional overhead to shipping the other binaries, iirc.

But I agree, that is against policy, but I slightly forgot about this part of the policy.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, you know me, I just like there to be a policy so I know what we're doing :D

| 9.4.4 | [1.10.0.0](https://github.com/haskell/haskell-language-server/releases/tag/1.10.0.0) | deprecated |
Expand Down