Add support for textDocument/prepareRename (added in LSP 3.12) #179
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wz1000
approved these changes
Jul 16, 2019
lukel97
reviewed
Jul 16, 2019
haskell-lsp-types/src/Language/Haskell/LSP/Types/DataTypesJSON.hs
Outdated
Show resolved
Hide resolved
Collaborator
|
Can you update the helper functions inside Capabilities.hs to reflect that this is available in 3.12? |
Collaborator
Author
|
Ah I see -- please double check it looks good now. |
lukel97
approved these changes
Jul 18, 2019
alanz
added a commit
that referenced
this pull request
Aug 25, 2019
The merge for #179 failed, and there were some bits missing for the full implementation of the feature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cf. issue #134