Tag names must start with a letter after 'tag:' and contain letters, … #342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…numbers, or dashes
|
Tailscale validates tags with code (tailCfg.CheckTag): https://github.com/tailscale/tailscale/blob/main/tailcfg/tailcfg.go#L589 And that is equivalent with this new regex. 👍 |
Good find! I swear I tried searching on the error messages in their repo but clearly didn't get the job done. |
frenck
approved these changes
Apr 22, 2024
frenck
added
the
bugfix
|
Great. Thank you both for you work maintaining this repository. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tag names must start with a letter after 'tag:' and contain letters, numbers, or dashes
Proposed Changes
I wanted to apply "tag:home-automation" to my HomeAssistant. This generated a regex validation error while "tag:h-omeautomation" was accepted. I didn't find Tailscale's regex for tags so I'm proposing a revision to accept multiple hyphens and in multiple locations. Tested against example tags in Common Patterns for Tag Names
Tested combinations to find Tailscale requires tags start with a letter and are composed of letters, numbers and dashes. Tags can be a single letter, e.g. "tag:a", and can end in a dash.
Related Issues
Commit 448b965