-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NDC Spec v0.2.0 support #666
Open
BenoitRanque
wants to merge
50
commits into
main
Choose a base branch
from
benoit/eng-362-update-ndc-postgres-to-ndc_models-020
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
4e3512c
Update to ndc-models 0.2.0
BenoitRanque e347827
scalar type representation is no longer optional. If the configuratio…
BenoitRanque d3359fd
We assume we don't support any capability we did not previously support.
BenoitRanque f1aac02
Foreign Keys moved from collections to object types.
BenoitRanque 86d601e
Count aggregates now take an expression instead of a column reference…
BenoitRanque c5cdb1f
remove todo
BenoitRanque 6aa62e1
remove todo, jandle a couple additional cases as errors/unsupported
BenoitRanque f2ba324
add additional error types
BenoitRanque 52292f6
add test for aggregate of nested field
BenoitRanque fb79bfb
relationship mapping now have an array on the right-hand side, so for…
BenoitRanque 1240ffb
scalar type no longer optional
BenoitRanque 7a227e8
nested field collection not supported, add error handling
BenoitRanque 3647605
update filtering, aggregates, sorting, to 0.2.0
BenoitRanque 89c17fa
Update translation test configurations to v5
BenoitRanque 7eaa240
add reference to query/mutation request schema json
BenoitRanque 2fb2fc8
right hand side of relationship column mapping is now an array
BenoitRanque 8970cfc
update aggregate expresion
BenoitRanque 4a64876
use exists instead of left-hand side path
BenoitRanque a4987c2
update root_collection_column test to use scopes instead
BenoitRanque e1c4e9a
Correct sorting behavior. We use CCUNT("col") for CountStar to count …
BenoitRanque 623ba65
use exists instead of left-hand side path
BenoitRanque b75dbc2
v0.2.0 schema update
BenoitRanque 8fae660
use exists instead of left-handed path
BenoitRanque 706ff96
right-hand side of relationship column mapping is now an array
BenoitRanque 3c5de38
use exists instead of left-hand side path
BenoitRanque 11511ed
aggregates have changed
BenoitRanque d0052c6
comparison target columns have been simplified
BenoitRanque 0a15b79
root column comparison now replaced with scopes
BenoitRanque fb69607
update tests to new sdk
BenoitRanque 6832dd9
add manually triggered tests to generate schema files for test file v…
BenoitRanque 3759591
remove debug print statement
BenoitRanque 35832ef
Fix aggregates for 0.2.0
BenoitRanque 80f4831
fix: sums that return int8 should be marked with the meaning field
BenoitRanque f93b943
We'll need to implement filtering by aggregates later
BenoitRanque b38a5a1
add standard comparison operators, make no changes to defaults
BenoitRanque 361a926
schema snapshots updated to reflect changes in sum aggregates defini…
BenoitRanque 4c8bad3
Replace RootAndCurrentTables with TableScope, which keeps track of an…
BenoitRanque 92bb23d
change default introspection settings to include meaning for gt(e),lt…
BenoitRanque c2f518e
update benchmark ndc request
BenoitRanque 3f5e42c
make prettier happy
BenoitRanque 1dd91a0
default to JSON representation if missing, instead of attempting to i…
BenoitRanque 00d1c18
use scalar type representation instead of scalar type name when decid…
BenoitRanque de590f1
add test for returning object relationship after insert
BenoitRanque a8e07e3
add nested/nested array relationships to postgres, required for retur…
BenoitRanque eb7dce6
mark nested array relationships as supported
BenoitRanque bea5b17
include types returning Int64AsString in sum functions
BenoitRanque 7330acc
fix formating
BenoitRanque 1161d5b
Run 0.2.0 e2e tests
danieljharvey 39d5962
Merge branch 'main' into benoit/eng-362-update-ndc-postgres-to-ndc_mo…
BenoitRanque dfeab82
update snapshots
BenoitRanque File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This now explicitly runs the new e2e tests that use
ndc-models 0.2.0