Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added all versions up to Ruby 3.4 to the CI matrix. #9

Merged
merged 2 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
strategy:
fail-fast: false
matrix:
ruby: ['2.7', '3.0', '3.1']
ruby: ['2.7', '3.0', '3.1', '3.2', '3.3', '3.4']
rails: ['6.1', '7.1']
env:
BUNDLE_GEMFILE: 'gemfiles/rails_${{ matrix.rails }}.gemfile'
Expand Down
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
### next

* TODO: Replace this bullet point with an actual description of a change.
* Added all versions up to Ruby 3.4 to the CI matrix (#9)

### 1.5.1 (17 January 2025)

Expand Down
16 changes: 8 additions & 8 deletions spec/boltless/result_row_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,12 @@
end

it 'includes the values' do
expect(action).to include('values=[{:name=>"Klaus"}]')
expect(action).to include(/values=\[{:?name(=>|: )"Klaus"}\]/)
end

it 'includes the meta' do
expect(action).to \
include('meta=[{:id=>146, :type=>"node", :deleted=>false}]')
parts = [':?id(=>|: )146', ':?type(=>|: )"node"', ':?deleted(=>|: )false']
expect(action).to include(/meta=\[{#{parts.join(', ')}}\]/)
end

it 'includes the graph' do
Expand Down Expand Up @@ -143,18 +143,18 @@
let(:input) { raw_result_fixture(:with_graph_result) }

it 'includes the graph (key)' do
expect(action).to include('graph={:nodes=>')
expect(action).to include(/graph={:?nodes(=>|: )/)
end

it 'includes the graph (nodes)' do
expect(action).to \
include('[{:id=>"149", :labels=>["User"], ' \
':properties=>{:name=>"Kalle"}}]')
parts = [':?id(=>|: )"149"', ':?labels(=>|: )\["User"\]',
':?properties(=>|: ){:?name(=>|: )"Kalle"}']
expect(action).to include(/\[{#{parts.join(', ')}}\]/)
end

it 'includes the graph (relationships)' do
expect(action).to \
include(':relationships=>[]')
include(/:?relationships(=>|: )\[\]/)
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion spec/boltless/result_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@
end

it 'includes the stats' do
expect(action).to include('stats={:contains_updates=>true')
expect(action).to include(/stats={:?contains_updates(=>|: )true/)
end
end

Expand Down